Jedd/cxpla 154 enforce nullability analysers in objects and use required #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-nullability-analysers-in-objects-and-use-required
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #202 +/- ##
===========================================
+ Coverage 57.26% 69.09% +11.82%
===========================================
Files 243 259 +16
Lines 10023 10739 +716
Branches 1090 1091 +1
===========================================
+ Hits 5740 7420 +1680
+ Misses 4026 2972 -1054
- Partials 257 347 +90 ☔ View full report in Codecov by Sentry. |
clairekuang
reviewed
Jan 15, 2025
…in-objects-and-use-required
clairekuang
approved these changes
Jan 15, 2025
| SetControlPoints(controlPoints); | ||
| } | ||
|
|
||
| public Surface(IList<double> pointData, int countU, int countV) |
There was a problem hiding this comment.
Likewise, if the previous constructor is used and we are recommending to not set pointData directly, this constructor should be removed instead
clairekuang
deleted the
jedd/cxpla-154-enforce-nullability-analysers-in-objects-and-use-required
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables for the
Speckle.Objectsproject the remaining nullability analysers for ensuring correct nullability and use ofrequiredkeyword of our object models.CS8618 - Non-nullable variable must contain a non-null value when exiting constructor.
requiredkeyword for Pontcloud and SurfaceSurfaceclass has some complex behaviour around the flattening the control point data for efficient serilization. For now I've had to expose a parametered constructor in addition torequiredproperties, we could simplyfy this by re-structuring the class a little.